Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sorting after renaming and checking/unchecking checklist item #43

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented May 16, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Currently, sorting in checklist is applied only after adding new item or reloading the app. This PR also adds sorting after renaming item and checking/unchecking.
    • Deleting also doesn't trigger sorting, but when other actions do it, delete doesn't need to sort.
  • Probably sorting after checking/unchecking should be done a bit nicer visually, maybe with some delay or animation so users will know what happened if a click was accidental.

Before/After Screenshots/Screen Record

  • Before:
qemu-system-x86_64_tiEIgMxH3L.mp4
  • After:
qemu-system-x86_64_CFMMmmATyC.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh naveensingh merged commit 508a401 into FossifyOrg:master Jul 18, 2024
1 check passed
@Aga-C Aga-C deleted the sorting-on-all-actions branch July 18, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically shift (un)selected items in list
2 participants